GitHub user zhouyejoe opened a pull request:

    https://github.com/apache/spark/pull/20744

    [SPARK-23608][CORE][WebUI] Add synchronization in SHS between attachSparkUI 
and detachSparkUI functions to avoid concurrent modification issue to Jetty 
Handlers

    Jetty handlers are dynamically attached/detached while SHS is running. But 
the attach and detach operations might be taking place at the same time due to 
the async in load/clear in Guava Cache. 
    
    ## What changes were proposed in this pull request?
    Add synchronization between attachSparkUI and detachSparkUI in SHS.
    
    ## How was this patch tested?
    With this patch, the jetty handlers missing issue never happens again in 
our production cluster SHS.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhouyejoe/spark SPARK-23608

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20744
    
----
commit f4118c03d7ea8cdd9ade5ec44db3e1bcb5f45535
Author: Ye Zhou <yezhou@...>
Date:   2018-03-06T02:19:17Z

    [SPARK-23608][CORE][WebUI] Add synchronization in SHS between attachSparkUI 
and detachSparkUI functions to avoid concurrent modification issue to Jetty 
Handlers.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to