Github user zhouyejoe commented on a diff in the pull request:
https://github.com/apache/spark/pull/20744#discussion_r172609731
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -148,14 +148,14 @@ class HistoryServer(
appId: String,
attemptId: Option[String],
ui: SparkUI,
- completed: Boolean) {
+ completed: Boolean) = this.synchronized {
assert(serverInfo.isDefined, "HistoryServer must be bound before
attaching SparkUIs")
ui.getHandlers.foreach(attachHandler)
addFilters(ui.getHandlers, conf)
}
/** Detach a reconstructed UI from this server. Only valid after bind().
*/
- override def detachSparkUI(appId: String, attemptId: Option[String], ui:
SparkUI): Unit = {
+ override def detachSparkUI(appId: String, attemptId: Option[String], ui:
SparkUI): Unit = this.synchronized {
--- End diff --
Thanks. Will fix the style violation.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
