Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20748#discussion_r172538524
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -93,6 +95,40 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks {
         }
       }
     
    +  protected def checkExceptionInExpression[T <: Throwable](
    +      expression: => Expression,
    +      inputRow: InternalRow,
    +      expectedErrMsg: String)(
    +      implicit classTag: ClassTag[T]): Unit = {
    +    val clazz = classTag.runtimeClass
    +    val serializer = new JavaSerializer(new SparkConf()).newInstance
    --- End diff --
    
    This code is also present in `checkEvaluation` can you factor it out into a 
common method?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to