Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r172661317
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -57,20 +59,20 @@
// The data stored in these two allocations need to maintain binary
compatible. We can
// directly pass this buffer to external components.
- private long nulls;
--- End diff --
What I mean is, we don't need to change `OffHeapColumnVectot` at all, if we
don't remove `Platform.reallocateMemory`. We should apply the new `MemoryBlock`
incrementally. I think applying it to `UTF8String` is a good start to prove the
performance advantage, but I don't think we need to rush to column vectors in
this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
