Github user cloud-fan commented on a diff in the pull request:
    --- Diff: 
    @@ -57,20 +59,20 @@
       // The data stored in these two allocations need to maintain binary 
compatible. We can
       // directly pass this buffer to external components.
    -  private long nulls;
    --- End diff --
    What I mean is, we don't need to change `OffHeapColumnVectot` at all, if we 
don't remove `Platform.reallocateMemory`. We should apply the new `MemoryBlock` 
incrementally. I think applying it to `UTF8String` is a good start to prove the 
performance advantage, but I don't think we need to rush to column vectors in 
this PR.


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to