Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r172708797
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -57,20 +59,20 @@
// The data stored in these two allocations need to maintain binary
compatible. We can
// directly pass this buffer to external components.
- private long nulls;
--- End diff --
I agree with incremental updates. Do we revert changes in
`OffHeapColumnVector` in this PR? In other words, we do not change
`OffHeapColumnVector` at all in this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
