GitHub user viirya reopened a pull request:

    [SPARK-23291][SQL][R] R's substr should not reduce starting position by 1 
when calling Scala API

    ## What changes were proposed in this pull request?
    Seems R's substr API treats Scala substr API as zero based and so subtracts 
the given starting position by 1.
    Because Scala's substr API also accepts zero-based starting position 
(treated as the first element), so the current R's substr test results are 
correct as they all use 1 as starting positions.
    ## How was this patch tested?
    Modified tests.

You can merge this pull request into a Git repository by running:

    $ git pull SPARK-23291

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20464
commit a2ffdc14ebfa67656e3598f0a0a0131f18f98aa5
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-02-01T03:10:53Z

    R's substr should not reduce starting position by 1 when calling Scala API.

commit 95c8a4e48e8f760bb9ca0df844136d19452521d7
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-02-01T09:02:16Z

    Add a note to migration guide of R doc.

commit d994d76d45e474b3e4a31fff8250c30efef6a757
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-02-02T08:30:43Z

    Fix doc.

commit 0ebdf74942e0894bfaf6cbede4c03fd3f5d26411
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-03-06T04:54:48Z

    Improve doc.



To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to