Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20757#discussion_r173132852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1416,13 +1417,42 @@ case class ValidateExternalType(child: Expression,
expected: DataType)
override def nullable: Boolean = child.nullable
- override def dataType: DataType =
RowEncoder.externalDataTypeForInput(expected)
-
- override def eval(input: InternalRow): Any =
- throw new UnsupportedOperationException("Only code-generated
evaluation is supported")
+ override val dataType: DataType =
RowEncoder.externalDataTypeForInput(expected)
private val errMsg = s" is not a valid external type for schema of
${expected.simpleString}"
+ private lazy val dataTypeClazz = if (dataType.isInstanceOf[ObjectType]) {
--- End diff --
Can we fold this into the `checkType` functions. I'd rather not deference a
lazy val every time we check a type.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
