Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20757#discussion_r173190616
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -121,6 +121,19 @@ object ScalaReflection extends ScalaReflection {
case _ => false
}
+ def classForNativeTypeOf(dt: DataType): Class[_] = dt match {
--- End diff --
There is a difference between how we implement an expression and how we use
an expression. In this case the implementations should behave the same, and not
only in the context in which it is being used.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
