Github user dvogelbacher commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20779#discussion_r173484471
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
 ---
    @@ -307,4 +309,47 @@ class WholeStageCodegenSuite extends QueryTest with 
SharedSQLContext {
           // a different query can result in codegen cache miss, that's by 
design
         }
       }
    +
    +  test("SPARK-23598: Avoid compilation error with a lot of aggregation 
operations") {
    --- End diff --
    
    It's not a compilation but a runtime error.  maybe better say: `codegen 
working for lots of aggregation operations without runtime errors`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to