Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20686#discussion_r173580016
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala ---
    @@ -108,5 +111,29 @@ trait MLTest extends StreamTest with TempDirectory { 
self: Suite =>
           otherResultCols: _*)(globalCheckFunction)
         testTransformerOnDF(dataframe, transformer, firstResultCol,
           otherResultCols: _*)(globalCheckFunction)
    +    }
    +
    +  def testTransformerByInterceptingException[A : Encoder](
    +    dataframe: DataFrame,
    +    transformer: Transformer,
    +    expectedMessagePart : String,
    +    firstResultCol: String) {
    +
    +    def hasExpectedMessage(exception: Throwable): Boolean =
    --- End diff --
    
    Since most other tests check parts of the message, I'm OK with this setup.  
When we don't think the message will remain stable, we can pass an empty string 
for expectedMessagePart.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to