Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20686#discussion_r173600463
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/VectorAssemblerSuite.scala ---
    @@ -76,16 +77,18 @@ class VectorAssemblerSuite
         val assembler = new VectorAssembler()
           .setInputCols(Array("a", "b", "c"))
           .setOutputCol("features")
    -    val thrown = intercept[IllegalArgumentException] {
    -      assembler.transform(df)
    -    }
    -    assert(thrown.getMessage contains
    +    testTransformerByInterceptingException[(String, String, String)](
    +      df,
    +      assembler,
           "Data type StringType of column a is not supported.\n" +
           "Data type StringType of column b is not supported.\n" +
    -      "Data type StringType of column c is not supported.")
    +      "Data type StringType of column c is not supported.",
    +      "features")
       }
     
    -  test("ML attributes") {
    +  ignore("ML attributes") {
    --- End diff --
    
    ditto: do not ignore


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to