Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20807#discussion_r174045577
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -496,7 +497,7 @@ private[yarn] class YarnAllocator(
           executorIdCounter += 1
           val executorHostname = container.getNodeId.getHost
           val containerId = container.getId
    -      val executorId = executorIdCounter.toString
    +      val executorId = (initialExecutorIdCounter + 
executorIdCounter).toString
    --- End diff --
    
    Yeah, this is an issue only when the application is quite fast. Do you have 
concerns in general solving this or related the fix in the first commit? Asking 
it because pausing the user class thread would be definitely better as I've 
written below.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to