Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20807#discussion_r174964951
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -417,8 +417,11 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments) extends
}
}
- private def sparkContextInitialized(sc: SparkContext) = {
+ private def sparkContextInitialized(sc: SparkContext) = synchronized {
--- End diff --
Some other code in this class uses synchronization on `this`, so I think it
would be better to synchronize on `sparkContextPromise` in this case.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
