Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20811#discussion_r174236490
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
 ---
    @@ -108,6 +109,8 @@ private[spark] class ExecutorPodFactory(
           nodeToLocalTaskCount: Map[String, Int]): Pod = {
         val name = s"$executorPodNamePrefix-exec-$executorId"
     
    +    val imagePullSecrets = imagePullSecret.map(new 
LocalObjectReference(_)).toList
    --- End diff --
    
    Given the same code is used to configure both the driver and executor pods, 
it can be extracted out into a utility method in `KubernetesUtil`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to