Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20799#discussion_r174294428
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
 ---
    @@ -247,6 +241,18 @@ private[yarn] class ExecutorRunnable(
     
         System.getenv().asScala.filterKeys(_.startsWith("SPARK"))
           .foreach { case (k, v) => env(k) = v }
    +
    +    sparkConf.getExecutorEnv.foreach { case (key, value) =>
    +      if (key == Environment.CLASSPATH.name()) {
    --- End diff --
    
    Ah, I see sorry missed that. So I guess here we are just stomping on 
whatever is in the system env path now, vs before we were stomping on the 
executorEnv specified with the system env.  


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to