Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20799#discussion_r174331279
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
 ---
    @@ -247,6 +241,18 @@ private[yarn] class ExecutorRunnable(
     
         System.getenv().asScala.filterKeys(_.startsWith("SPARK"))
           .foreach { case (k, v) => env(k) = v }
    +
    +    sparkConf.getExecutorEnv.foreach { case (key, value) =>
    +      if (key == Environment.CLASSPATH.name()) {
    +        // If the key of env variable is CLASSPATH, we assume it is a path 
and append it.
    +        // This is kept for backward compatibility and consistency with 
hadoop
    +        YarnSparkHadoopUtil.addPathToEnvironment(env, key, value)
    +      } else {
    +        // For other env variables, simply overwrite the value.
    +        env(key) = value
    +      }
    +    }
    --- End diff --
    
    Sure, I will fix it, thanks for the reminder.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to