Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175393443
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -31,24 +31,24 @@
* for each incoming record, we should call `reset` of BufferHolder
instance before write the record
* and reuse the data buffer.
*
- * Generally we should call `UnsafeRow.setTotalSize` and pass in
`BufferHolder.totalSize` to update
+ * Generally we should call `UnsafeRowWriter.setTotalSize` using
`BufferHolder.totalSize` to update
* the size of the result row, after writing a record to the buffer.
However, we can skip this step
* if the fields of row are all fixed-length, as the size of result row is
also fixed.
*/
-public class BufferHolder {
+public final class BufferHolder {
--- End diff --
Why is this still public since you are making everything package private?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
