Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20850#discussion_r175363603
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
 ---
    @@ -86,11 +86,17 @@ public void grow(int neededSize) {
         }
       }
     
    -  public void reset() {
    +  byte[] buffer() { return buffer; }
    --- End diff --
    
    nit: need line feeds to make styles along with other code? 
https://github.com/apache/spark/blob/4de638c1976dea74761bbe5c30da808178ee885d/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java#L197
    ```
    byte[] buffer() {
      return buffer;
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to