Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20803#discussion_r175609377
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -166,20 +168,28 @@ private[sql] object Dataset {
     class Dataset[T] private[sql](
         @transient val sparkSession: SparkSession,
         @DeveloperApi @InterfaceStability.Unstable @transient val 
queryExecution: QueryExecution,
    -    encoder: Encoder[T])
    +    encoder: Encoder[T],
    +    val sqlText: String = "")
    --- End diff --
    
    And how does the SQL shell execute commands? like `SELECT * FROM ...`, does 
it display all the rows or add a LIMIT before displaying? Generally we should 
not propagate sql text, as a new DataFrame usually means the plan is changed, 
the SQL text is not accurate anymore.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to