Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20803#discussion_r176313994
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala 
---
    @@ -635,7 +637,8 @@ class SparkSession private(
        * @since 2.0.0
        */
       def sql(sqlText: String): DataFrame = {
    -    Dataset.ofRows(self, sessionState.sqlParser.parsePlan(sqlText))
    +    Dataset.ofRows(self, sessionState.sqlParser.parsePlan(sqlText),
    +      substitutor.substitute(sqlText))
    --- End diff --
    
    You may want to refactor this PR into `ParserExtension` and UI part. I 
think that will be less intrusive than the current implementation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to