Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20786#discussion_r175957767
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
    @@ -135,32 +175,59 @@ class LeafNode private[ml] (
     
       override private[ml] def maxSplitFeatureIndex(): Int = -1
     
    +}
    +
    +/**
    + * Decision tree leaf node for classification.
    + * @param prediction  Prediction this node makes
    --- End diff --
    
    I think you don't need to add these Param doc strings since you're 
overriding methods with doc strings.  The base trait doc string should show up. 
 (here and elsewhere)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to