Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20786#discussion_r175958393
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
    @@ -240,6 +302,69 @@ private object InternalNode {
       }
     }
     
    +/**
    + * Internal Decision Tree node for regression.
    + * @param prediction  Prediction this node would make if it were a leaf 
node
    + * @param impurity  Impurity measure at this node (for training data)
    + * @param gain Information gain value. Values less than 0 indicate missing 
values;
    + *             this quirk will be removed with future updates.
    + * @param leftChild  Left-hand child node
    + * @param rightChild  Right-hand child node
    + * @param split  Information about the test used to split to the left or 
right child.
    + */
    +class ClassificationInternalNode private[ml] (
    +    override val prediction: Double,
    +    override val impurity: Double,
    +    override val gain: Double,
    +    override val leftChild: ClassificationNode,
    +    override val rightChild: ClassificationNode,
    +    val split: Split,
    --- End diff --
    
    override?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to