Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20633#discussion_r175966231
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -169,4 +179,54 @@ class DefaultReadWriteSuite extends SparkFunSuite with
MLlibTestSparkContext
val myParams = new MyParams("my_params")
testDefaultReadWrite(myParams)
}
+
+ test("default param shouldn't become user-supplied param after
persistence") {
+ val myParams = new MyParams("my_params")
+ myParams.set(myParams.shouldNotSetIfSetintParamWithDefault, 1)
+ myParams.checkExclusiveParams()
+ val loadedMyParams = testDefaultReadWrite(myParams)
+ loadedMyParams.checkExclusiveParams()
+ assert(loadedMyParams.getDefault(loadedMyParams.intParamWithDefault) ==
+ myParams.getDefault(myParams.intParamWithDefault))
+
+ loadedMyParams.set(myParams.intParamWithDefault, 1)
+ intercept[SparkException] {
+ loadedMyParams.checkExclusiveParams()
+ }
+ }
+
+ test("User-suppiled value for default param should be kept after
persistence") {
+ val myParams = new MyParams("my_params")
+ myParams.set(myParams.intParamWithDefault, 100)
+ val loadedMyParams = testDefaultReadWrite(myParams)
+ assert(loadedMyParams.get(myParams.intParamWithDefault).get == 100)
+ }
+
+ test("Read metadata without default field prior to 2.4") {
--- End diff --
Nice! I like this setup.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
