Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20633#discussion_r175962188
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -296,14 +297,19 @@ private[ml] object DefaultParamsWriter {
paramMap: Option[JValue] = None): String = {
val uid = instance.uid
val cls = instance.getClass.getName
- val params =
instance.extractParamMap().toSeq.asInstanceOf[Seq[ParamPair[Any]]]
+ val params = instance.paramMap.toSeq
+ val defaultParams = instance.defaultParamMap.toSeq
val jsonParams = paramMap.getOrElse(render(params.map { case
ParamPair(p, v) =>
p.name -> parse(p.jsonEncode(v))
}.toList))
+ val jsonDefaultParams = render(defaultParams.map { case ParamPair(p,
v) =>
+ p.name -> parse(p.jsonEncode(v))
+ }.toList)
val basicMetadata = ("class" -> cls) ~
("timestamp" -> System.currentTimeMillis()) ~
("sparkVersion" -> sc.version) ~
("uid" -> uid) ~
+ ("defaultParamMap" -> jsonDefaultParams) ~
--- End diff --
nit: How about putting this below paramMap since that's nicer for viewing
the JSON?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
