GitHub user rednaxelafx opened a pull request:

    https://github.com/apache/spark/pull/20870

    [SPARK-23760][SQL]: CodegenContext.withSubExprEliminationExprs should 
save/restore CSE state correctly

    ## What changes were proposed in this pull request?
    
    Fixed `CodegenContext.withSubExprEliminationExprs()` so that it 
saves/restores CSE state correctly.
    
    ## How was this patch tested?
    
    Added new unit test to verify that the old CSE state is indeed saved and 
restored around the `withSubExprEliminationExprs()` call. Manually verified 
that this test fails without this patch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rednaxelafx/apache-spark codegen-subexpr-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20870
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to