Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20870#discussion_r175986986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -942,7 +940,7 @@ class CodegenContext {
def subexpressionEliminationForWholeStageCodegen(expressions:
Seq[Expression]): SubExprCodes = {
// Create a clear EquivalentExpressions and SubExprEliminationState
mapping
val equivalentExpressions: EquivalentExpressions = new
EquivalentExpressions
- val subExprEliminationExprs = mutable.HashMap.empty[Expression,
SubExprEliminationState]
+ val localSubExprEliminationExprs = mutable.HashMap.empty[Expression,
SubExprEliminationState]
--- End diff --
This renaming isn't necessary for the fix per-se, but I'd like to piggyback
it on this change so that it's clearer that we're not interfering with the
current CSE state of this CodegenContext here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
