Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2933#issuecomment-60525495
I find this a little bit hacky. If the broadcast implementation has bugs or
performance issues, we should just fix them and it will stabalize over time
like any other new features we add. Having this mode where we might do one
thing and might do another, it will make debugging and measuring things
trickier. And we'll expose this configuration option which it seems like
ultimately we will want to remove.
IMO this would only be justified if we had a well documented performance
issue that we felt we simply can't solve within the broadcast architecture,
then you would give a latch here for people to avoid broadcasting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
