Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177267477
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,25 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.spark.deploy.k8s.submit.steps
+package org.apache.spark.deploy.k8s
-import org.apache.spark.deploy.k8s.MountSecretsBootstrap
-import org.apache.spark.deploy.k8s.submit.KubernetesDriverSpec
+import io.fabric8.kubernetes.api.model.HasMetadata
-/**
- * A driver configuration step for mounting user-specified secrets onto
user-specified paths.
- *
- * @param bootstrap a utility actually handling mounting of the secrets.
- */
-private[spark] class DriverMountSecretsStep(
- bootstrap: MountSecretsBootstrap) extends DriverConfigurationStep {
+private[k8s] case class KubernetesSpec(
+ pod: SparkPod,
+ additionalDriverKubernetesResources: Seq[HasMetadata],
+ podJavaSystemProperties: Map[String, String])
--- End diff --
Can we shorten the name to just `systemProperties`? One of the most
frequent types of comments I got while working on the upstreaming was to use
short names.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
