Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177269929
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.submit
+
+import org.apache.spark.deploy.k8s.{KubernetesConf,
KubernetesDriverSpecificConf, KubernetesRoleSpecificConf, KubernetesSpec}
+import org.apache.spark.deploy.k8s.features.{BasicDriverFeatureStep,
DriverKubernetesCredentialsFeatureStep, DriverServiceFeatureStep,
MountSecretsFeatureStep}
+
+private[spark] class KubernetesDriverBuilder(
+ provideBasicStep: (KubernetesConf[KubernetesDriverSpecificConf]) =>
BasicDriverFeatureStep =
+ new BasicDriverFeatureStep(_),
+ provideCredentialsStep: (KubernetesConf[KubernetesDriverSpecificConf])
+ => DriverKubernetesCredentialsFeatureStep =
+ new DriverKubernetesCredentialsFeatureStep(_),
+ provideServiceStep: (KubernetesConf[KubernetesDriverSpecificConf]) =>
DriverServiceFeatureStep =
+ new DriverServiceFeatureStep(_),
+ provideSecretsStep: (KubernetesConf[_ <: KubernetesRoleSpecificConf]
+ => MountSecretsFeatureStep) =
+ new MountSecretsFeatureStep(_)) {
+
+ def buildFromFeatures(
+ kubernetesConf: KubernetesConf[KubernetesDriverSpecificConf]):
KubernetesSpec = {
+ val baseFeatures = Seq(
+ provideBasicStep(kubernetesConf),
+ provideCredentialsStep(kubernetesConf),
+ provideServiceStep(kubernetesConf))
+ val allFeatures = if
(kubernetesConf.roleSecretNamesToMountPaths.nonEmpty) {
+ baseFeatures ++ Seq(provideSecretsStep(kubernetesConf))
+ } else baseFeatures
+ var spec =
KubernetesSpec.initialSpec(kubernetesConf.sparkConf.getAll.toMap)
--- End diff --
Can you add a new line before this line?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
