Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r177404199
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/XXH64.java
---
@@ -71,40 +74,47 @@ public static long hashLong(long input, long seed) {
return fmix(hash);
}
- public long hashUnsafeWords(Object base, long offset, int length) {
- return hashUnsafeWords(base, offset, length, seed);
+ public long hashUnsafeWordsBlock(MemoryBlock mb) {
+ return hashUnsafeWordsBlock(mb, seed);
}
- public static long hashUnsafeWords(Object base, long offset, int length,
long seed) {
- assert (length % 8 == 0) : "lengthInBytes must be a multiple of 8
(word-aligned)";
- long hash = hashBytesByWords(base, offset, length, seed);
+ public static long hashUnsafeWordsBlock(MemoryBlock mb, long seed) {
+ assert (mb.size() % 8 == 0) : "lengthInBytes must be a multiple of 8
(word-aligned)";
+ long hash = hashBytesByWordsBlock(mb, seed);
return fmix(hash);
}
public long hashUnsafeBytes(Object base, long offset, int length) {
return hashUnsafeBytes(base, offset, length, seed);
}
- public static long hashUnsafeBytes(Object base, long offset, int length,
long seed) {
+ public static long hashUnsafeBytesBlock(MemoryBlock mb, long seed) {
+ Object base = mb.getBaseObject();
--- End diff --
where do we use base?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
