Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r177686329
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -77,7 +81,8 @@
        */
       public static UTF8String fromBytes(byte[] bytes) {
         if (bytes != null) {
    -      return new UTF8String(bytes, BYTE_ARRAY_OFFSET, bytes.length);
    +      return new UTF8String(
    +        MemoryBlock.allocateFromObject(bytes, BYTE_ARRAY_OFFSET, 
bytes.length));
    --- End diff --
    
    we can create `ByteArrayMemoryBlock` directly here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to