Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20962#discussion_r178692018
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -454,6 +454,32 @@ def isin(self, *cols):
         >>> df.select(df.name).orderBy(df.name.asc()).collect()
         [Row(name=u'Alice'), Row(name=u'Tom')]
         """
    +    _asc_nulls_first_doc = """
    +    Returns a sort expression based on the ascending order of the given 
column name and null values
    +    return before non-null values
    +
    +    >>> from pyspark.sql import Row
    --- End diff --
    
    @huaxingao, btw, mind if I ask to double check if this doctest is actually 
ran? I remember I checked this several times and feel sure it runs but you know 
.. just in case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to