Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20962#discussion_r178957855
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -454,6 +454,32 @@ def isin(self, *cols):
         >>> df.select(df.name).orderBy(df.name.asc()).collect()
         [Row(name=u'Alice'), Row(name=u'Tom')]
         """
    +    _asc_nulls_first_doc = """
    +    Returns a sort expression based on the ascending order of the given 
column name and null values
    +    return before non-null values
    +
    +    >>> from pyspark.sql import Row
    --- End diff --
    
    @HyukjinKwon Thank you very much for reviewing my changes! I verified the 
doctest using 
    ```
    SPARK_TESTING=1 ./bin/pyspark pyspark.sql.column
    ```
    It ran OK 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to