Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r179182498
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -420,63 +432,53 @@ private[spark] class ExecutorAllocationManager(
* Request the cluster manager to remove the given executors.
* Returns the list of executors which are removed.
*/
- private def removeExecutors(executors: Seq[String]): Seq[String] =
synchronized {
- val executorIdsToBeRemoved = new ArrayBuffer[String]
-
+ private def removeExecutors(executors: Seq[String]): Unit = synchronized
{
--- End diff --
Since you're not actually removing executors here immediately with the new
cache recovery path, you should update the doc to describe that too.
Also we only mention the return type if we've got something interesting to
say about it, so you can just skip mentioning it entirely.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
