Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r179183962
--- Diff:
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
@@ -449,18 +457,26 @@ class ExecutorAllocationManagerSuite
assert(executorIds(manager).size === 12)
assert(numExecutorsTarget(manager) === 8)
- assert(removeExecutor(manager, "1"))
- assert(removeExecutors(manager, Seq("2", "3", "4")) === Seq("2", "3",
"4"))
- assert(!removeExecutor(manager, "5")) // lower limit reached
- assert(!removeExecutor(manager, "6"))
+ removeExecutor(manager, "1")
+ assert(executorsPendingToRemove(manager).contains("1"))
+ removeExecutors(manager, Seq("2", "3", "4"))
+ assert(executorsPendingToRemove(manager).contains("2"))
+ assert(executorsPendingToRemove(manager).contains("3"))
+ assert(executorsPendingToRemove(manager).contains("4"))
+ removeExecutor(manager, "5") // lower limit reached
+ assert(!executorsPendingToRemove(manager).contains("5"))
+ removeExecutor(manager, "6")
+ assert(!executorsPendingToRemove(manager).contains("6"))
+ removeExecutor(manager, "5") // lower limit reached
--- End diff --
I don't think this is supposed to be here twice (also on L466)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
