Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179270994
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -175,49 +138,41 @@ private[spark] class ExecutorPodFactory(
.withPorts(requiredPorts.asJava)
.addToArgs("executor")
.build()
-
- val executorPod = new PodBuilder()
- .withNewMetadata()
- .withName(name)
- .withLabels(resolvedExecutorLabels.asJava)
- .withAnnotations(executorAnnotations.asJava)
- .withOwnerReferences()
- .addNewOwnerReference()
- .withController(true)
- .withApiVersion(driverPod.getApiVersion)
- .withKind(driverPod.getKind)
- .withName(driverPod.getMetadata.getName)
- .withUid(driverPod.getMetadata.getUid)
- .endOwnerReference()
- .endMetadata()
- .withNewSpec()
- .withHostname(hostname)
- .withRestartPolicy("Never")
- .withNodeSelector(nodeSelector.asJava)
- .endSpec()
- .build()
-
val containerWithLimitCores = executorLimitCores.map { limitCores =>
val executorCpuLimitQuantity = new QuantityBuilder(false)
.withAmount(limitCores)
.build()
new ContainerBuilder(executorContainer)
.editResources()
- .addToLimits("cpu", executorCpuLimitQuantity)
- .endResources()
+ .addToLimits("cpu", executorCpuLimitQuantity)
--- End diff --
Just curious. Do we not support executor CPU request?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
