Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r180535990
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,17 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.spark.deploy.k8s.submit.steps
+package org.apache.spark.deploy.k8s
-import org.apache.spark.deploy.k8s.submit.KubernetesDriverSpec
+import io.fabric8.kubernetes.api.model.HasMetadata
-/**
- * Represents a step in configuring the Spark driver pod.
- */
-private[spark] trait DriverConfigurationStep {
+private[spark] case class KubernetesSpec(
--- End diff --
This class is named as though it applies to driver and executor
construction. Maybe `KubernetesDriverSpec`? It's also a bit unclear to me what
purpose this abstraction serves as opposed to the way
`KubernetesExecutorBuilder` goes about building the pod.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
