Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r179320302
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java
 ---
    @@ -0,0 +1,127 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.unsafe.memory;
    +
    +import com.google.common.primitives.Ints;
    +
    +import org.apache.spark.unsafe.Platform;
    +
    +/**
    + * A consecutive block of memory with a byte array on Java heap.
    + */
    +public final class ByteArrayMemoryBlock extends MemoryBlock {
    +
    +  private final byte[] array;
    +
    +  public ByteArrayMemoryBlock(byte[] obj, long offset, long size) {
    +    super(obj, offset, size);
    +    this.array = obj;
    +    assert(offset + size <= Platform.BYTE_ARRAY_OFFSET + obj.length) :
    +      "The sum of size " + size + " and offset " + offset + " should not 
be larger than " +
    +        "the array size " + (obj.length + Platform.BYTE_ARRAY_OFFSET);
    +  }
    +
    +  public ByteArrayMemoryBlock(long length) {
    +    this(new byte[Ints.checkedCast(length)], Platform.BYTE_ARRAY_OFFSET, 
length);
    +  }
    +
    +  @Override
    +  public MemoryBlock subBlock(long offset, long size) {
    +    checkSubBlockRange(offset, size);
    +    return new ByteArrayMemoryBlock(array, this.offset + offset, size);
    +  }
    +
    +  public byte[] getByteArray() { return array; }
    +
    +  /**
    +   * Creates a memory block pointing to the memory used by the byte array.
    +   */
    +  public static ByteArrayMemoryBlock fromArray(final byte[] array) {
    +    return new ByteArrayMemoryBlock(array, Platform.BYTE_ARRAY_OFFSET, 
array.length);
    +  }
    +
    +  @Override
    +  public final int getInt(long offset) {
    +    return Platform.getInt(array, this.offset + offset);
    +  }
    +
    +  @Override
    +  public final void putInt(long offset, int value) {
    +    Platform.putInt(array, this.offset + offset, value);
    +  }
    +
    +  @Override
    +  public final boolean getBoolean(long offset) {
    +    return Platform.getBoolean(array, this.offset + offset);
    +  }
    +
    +  @Override
    +  public final void putBoolean(long offset, boolean value) {
    +    Platform.putBoolean(array, this.offset + offset, value);
    +  }
    +
    +  @Override
    +  public final byte getByte(long offset) {
    +    return array[(int)(this.offset + offset - Platform.BYTE_ARRAY_OFFSET)];
    +  }
    +
    +  @Override
    +  public final void putByte(long offset, byte value) {
    +    array[(int)(this.offset + offset - Platform.BYTE_ARRAY_OFFSET)] = 
value;
    --- End diff --
    
    ditto.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to