GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/20991
[SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors
## What changes were proposed in this pull request?
This PR fixes the following errors in [Java
lint](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/7717/console)
after #19222 has been merged.
```
[ERROR]
src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java:[57] (sizes)
LineLength: Line is longer than 100 characters (found 106).
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java:[26,8]
(imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java:[23,10]
(modifier) ModifierOrder: 'public' modifier out of order with the JLS
suggestions.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[64,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[69,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[74,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[79,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[84,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[89,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[94,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[99,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[104,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[109,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[114,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[119,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[124,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[129,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[60,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[65,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[70,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[75,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[80,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[85,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[90,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[95,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[100,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[105,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[110,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[115,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[120,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[125,10]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java:[114,16]
(modifier) ModifierOrder: 'static' modifier out of order with the JLS
suggestions.
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java:[20,8]
(imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.
[ERROR]
src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[30,8]
(imports) UnusedImports: Unused import -
org.apache.spark.unsafe.memory.MemoryBlock.
[ERROR]
src/test/java/org/apache/spark/unsafe/memory/MemoryBlockSuite.java:[126,15]
(naming) MethodName: Method name 'ByteArrayMemoryBlockTest' must match pattern
'^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR]
src/test/java/org/apache/spark/unsafe/memory/MemoryBlockSuite.java:[143,15]
(naming) MethodName: Method name 'OnHeapMemoryBlockTest' must match pattern
'^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR]
src/test/java/org/apache/spark/unsafe/memory/MemoryBlockSuite.java:[160,15]
(naming) MethodName: Method name 'OffHeapArrayMemoryBlockTest' must match
pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/XXH64.java:[19,8]
(imports) UnusedImports: Unused import - com.google.common.primitives.Ints.
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/XXH64.java:[21,8]
(imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.
[ERROR]
src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[20,8]
(imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.
```
## How was this patch tested?
Existing UTs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiszk/spark SPARK-10399-jlint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20991
----
commit 25904bb837fde8575db84ccdd452a3cff6bbd3af
Author: Kazuaki Ishizaki <ishizaki@...>
Date: 2018-04-06T05:49:04Z
Fix java lint errors
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
