Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20991#discussion_r179669069
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java 
---
    @@ -54,7 +54,7 @@ public static int roundNumberOfBytesToNearestWord(int 
numBytes) {
        * @return true if the arrays are equal, false otherwise
        */
       public static boolean arrayEqualsBlock(
    -      MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long 
rightOffset, final long length) {
    +      MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long 
rightOffset, long length) {
    --- End diff --
    
    Maybe we can remove `final` from L67 as well?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to