Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r179824556
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -102,10 +102,11 @@ object KolmogorovSmirnovTest {
*/
@Since("2.4.0")
@varargs
- def test(dataset: DataFrame, sampleCol: String, distName: String,
params: Double*): DataFrame = {
+ def test(dataset: Dataset[_], sampleCol: String, distName: String,
params: Double*)
--- End diff --
nit: This doesn't fit scala style; please get familiar with the style we
use for multi-line function headers! Just check out other parts of MLlib for
examples.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
