Github user edwinalu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20940#discussion_r179978182
  
    --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
    @@ -268,6 +268,9 @@ private class LiveExecutor(val executorId: String, 
_addTime: Long) extends LiveE
     
       def hasMemoryInfo: Boolean = totalOnHeap >= 0L
     
    +  // peak values for executor level metrics
    +  var peakExecutorMetrics = new PeakExecutorMetrics
    --- End diff --
    
    Yes, thanks for catching this, it should be val.
    
    This is more properly part of SPARK-23431, and I can remove for now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to