Github user edwinalu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20940#discussion_r180180795
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -772,6 +772,12 @@ private[spark] class Executor(
         val accumUpdates = new ArrayBuffer[(Long, Seq[AccumulatorV2[_, _]])]()
         val curGCTime = computeTotalGcTime()
     
    +    // get executor level memory metrics
    +    val executorUpdates = new ExecutorMetrics(System.currentTimeMillis(),
    +      ManagementFactory.getMemoryMXBean.getHeapMemoryUsage().getUsed(),
    --- End diff --
    
    We could add 
ManagementFactory.getMemoryMXBean.getNonHeapMemoryUsage().getUsed(), for total 
non-heap memory used by the JVM.
    
    For direct and memory mapped usage, would collecting these be similar to 
https://gist.github.com/t3rmin4t0r/1a753ccdcfa8d111f07c ? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to