Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20940#discussion_r180199472
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -772,6 +772,12 @@ private[spark] class Executor(
         val accumUpdates = new ArrayBuffer[(Long, Seq[AccumulatorV2[_, _]])]()
         val curGCTime = computeTotalGcTime()
     
    +    // get executor level memory metrics
    +    val executorUpdates = new ExecutorMetrics(System.currentTimeMillis(),
    +      ManagementFactory.getMemoryMXBean.getHeapMemoryUsage().getUsed(),
    --- End diff --
    
    to be honest I haven't tried this out myself, I only knew this was 
possible.  The version I was familiar with is whats used by the dropwizard 
metrics
    
    
https://github.com/dropwizard/metrics/blob/4.1-development/metrics-jvm/src/main/java/com/codahale/metrics/jvm/BufferPoolMetricSet.java
    
    sorry you'll need to experiment with it a bit.  (again, not a blocker for 
this)
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to