GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/2966
[SPARK-4102] Remove unused ShuffleReader.stop() method.
This method is not implemented by the only subclass
(HashShuffleReader), nor is it ever called. While the
use of Scala's fancy "???" was pretty exciting, the method's
existence can only lead to confusion and it therefore should
be deleted.
@mateiz was there a reason for adding this that I'm
missing?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kayousterhout/spark-1 SPARK-4102
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2966
----
commit 904655e218f58b207e89030126bca124a91abb65
Author: Kay Ousterhout <[email protected]>
Date: 2014-10-27T21:29:26Z
[SPARK-4102] Remove unused ShuffleReader.stop() method.
This method is not implemented by the only subclass
(HashShuffleReader), nor is it ever called. While the
use of Scala's fancy "???" was pretty exciting, the method's
existence can only lead to confusion and it therefore should
be deleted.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
