Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/2966#issuecomment-60690881
But if other shuffle managers implement this, it won't ever be called,
which seems confusing/misleading. Do you mean we should add a call to
ShuffleReader.stop() somewhere?
On Mon, Oct 27, 2014 at 5:02 PM, Matei Zaharia <[email protected]>
wrote:
> BTW the ??? should indeed be changed to {}, it's weird that it says not
> implemented.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2966#issuecomment-60690706>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]