Github user gengliangwang commented on the issue:

    https://github.com/apache/spark/pull/21029
  
    +1
    From the PR #20933, we can see that there is a lot of common code between 
`DataReaderFactory[ColumnarBatch]` and `DataReaderFactory[UnsafeRow]`, if we 
use the current method factory pattern.
    This change makes data source implementation easier, and we don't need to 
do runtime type cast.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to