Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20910#discussion_r180782338
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
 ---
    @@ -14,17 +14,18 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.spark.deploy.k8s.submit.steps
    +package org.apache.spark.deploy.k8s
     
    -import org.apache.spark.deploy.k8s.submit.KubernetesDriverSpec
    +import io.fabric8.kubernetes.api.model.HasMetadata
     
    -/**
    - * Represents a step in configuring the Spark driver pod.
    - */
    -private[spark] trait DriverConfigurationStep {
    +private[spark] case class KubernetesSpec(
    --- End diff --
    
    If you check `KubernetesClientApplication`, it needs the extra fields here 
(the additional driver resources and the driver system properties) to construct 
the pod. In other words, the driver builder has to return a structure with more 
than just the pod.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to