Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20560#discussion_r179003707
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -274,3 +279,7 @@ abstract class BinaryNode extends LogicalPlan {
     
       override final def children: Seq[LogicalPlan] = Seq(left, right)
     }
    +
    +abstract class KeepOrderUnaryNode extends UnaryNode {
    --- End diff --
    
    `OrderPreservingUnaryNode`? Or perhaps do you think this would be better 
modeled as a mixin trait?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to