Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/19381#discussion_r180997645
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -192,12 +192,12 @@ abstract class ClassificationModel[FeaturesType, M <:
ClassificationModel[Featur
/**
* Predict label for the given features.
- * This internal method is used to implement `transform()` and output
[[predictionCol]].
+ * This method is used to implement `transform()` and output
[[predictionCol]].
*
* This default implementation for classification predicts the index of
the maximum value
* from `predictRaw()`.
*/
- override protected def predict(features: FeaturesType): Double = {
+ override def predict(features: FeaturesType): Double = {
--- End diff --
Is @Since annotation needed here? @WeichenXu123
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
